Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 6334015: Support StringLength in hydrogen (similar to ArrayLength). (Closed)

Created:
9 years, 11 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Support StringLength in hydrogen (similar to ArrayLength). To avoid deopts a few extra changes were needed: o Enable megamorphic state for special property loads on primitives. We used to flip between monomorphic stubs. o Extract pure string (no string wrapper support) version of the string length stub. Committed: http://code.google.com/p/v8/source/detail?r=6472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -72 lines) Patch
M src/arm/ic-arm.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +16 lines, -12 lines 0 comments Download
M src/ast.h View 3 chunks +8 lines, -5 lines 0 comments Download
M src/ast.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +17 lines, -13 lines 0 comments Download
M src/ic.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic.cc View 4 chunks +33 lines, -20 lines 0 comments Download
M src/stub-cache.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/ic-x64.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 11 months ago (2011-01-25 12:42:25 UTC) #1
fschneider
9 years, 11 months ago (2011-01-25 14:56:41 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698