Issue 6334007: ARM: Implement StringCharAtStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6334007: ARM: Implement StringCharAtStub. (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Implement StringCharAtStub. Committed: http://code.google.com/p/v8/source/detail?r=6390

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -2 lines)			Patch
	M	src/arm/code-stubs-arm.cc	View		2 chunks	+50 lines, -1 line	2 comments	Download
	M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

http://codereview.chromium.org/6334007/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6334007/diff/1/src/arm/code-stubs-arm.cc#newcode4906 src/arm/code-stubs-arm.cc:4906: StubRuntimeCallHelper call_helper; Control never goes here.

9 years, 11 months ago (2011-01-19 11:18:03 UTC) #2

Mads Ager (chromium)

9 years, 11 months ago (2011-01-19 11:32:42 UTC) #3

LGTM

Expand Messages | Collapse Messages