Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 6334003: Created a 'TextMenu' utility function. (Closed)

Created:
9 years, 11 months ago by diandersAtChromium
Modified:
9 years, 6 months ago
Reviewers:
davidjames
CC:
sosa, chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Created a 'TextMenu' utility function. This works similarly to bash's 'select' command, but is in python: select foo in "Tom" "Jerry" "Itchy" "Scratchy"; do echo $foo break done See also: http://codereview.chromium.org/6005004/ ...this was broken out of that massive CL. Change-Id: I38782b4dd6e7ef1af7d92b1975c9a9fd27ae6ee7 BUG=chromium-os:10556 TEST=Ran with --test as well as various sets of params; using this in WIP chromite. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bf34536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -0 lines) Patch
A lib/text_menu.py View 1 chunk +198 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
diandersAtChromium
David, I broke this out of the big CL to make it more manageable: http://codereview.chromium.org/6005004/ ...
9 years, 11 months ago (2011-01-14 00:55:23 UTC) #1
diandersAtChromium
David, Just a quick ping on this. If you don't have time to review it ...
9 years, 11 months ago (2011-01-18 18:31:54 UTC) #2
davidjames
9 years, 11 months ago (2011-01-18 21:09:04 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698