Issue 6334001: [gtk] shenanigans to get the confirm infobar's text to shrink/hide before the buttons do.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6334001: [gtk] shenanigans to get the confirm infobar's text to shrink/hide before the buttons do. (Closed)

Created:
9 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Mike Mammarella, Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[gtk] shenanigans to get the confirm infobar's text to shrink/hide before the buttons do. BUG=68782 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71385

Patch Set 2 : remove dbging code #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	chrome/browser/gtk/infobar_gtk.cc	View	1	2 chunks	+15 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Mammarella

LGTM http://codereview.chromium.org/6334001/diff/3001/chrome/browser/gtk/infobar_gtk.cc File chrome/browser/gtk/infobar_gtk.cc (right): http://codereview.chromium.org/6334001/diff/3001/chrome/browser/gtk/infobar_gtk.cc#newcode410 chrome/browser/gtk/infobar_gtk.cc:410: if (link_text.empty()) Is this related to the bug, ...

9 years, 11 months ago (2011-01-13 23:01:12 UTC) #2

Evan Stade

9 years, 11 months ago (2011-01-13 23:14:17 UTC) #3

http://codereview.chromium.org/6334001/diff/3001/chrome/browser/gtk/infobar_g...
File chrome/browser/gtk/infobar_gtk.cc (right):

http://codereview.chromium.org/6334001/diff/3001/chrome/browser/gtk/infobar_g...
chrome/browser/gtk/infobar_gtk.cc:410: if (link_text.empty())
On 2011/01/13 23:01:12, Mike Mammarella wrote:
> Is this related to the bug, or just incidentally also something that you
noticed
> while working on this code?

incidental. I noticed that for the sessions restore infobar, the (empty) link
leaves a small square that causes the cursor to change when it hovers it.

Expand Messages | Collapse Messages

Issue 6334001: [gtk] shenanigans to get the confirm infobar's text to shrink/hide before the buttons do. (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove dbging code #

Messages