Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 6332022: Adding vendor prefix to Locale class (becoming v8Locale) to minimize risk of ... (Closed)

Created:
9 years, 11 months ago by Nebojša Ćirić
Modified:
9 years, 7 months ago
CC:
v8-dev, darin (slow to review), jungshik at Google
Visibility:
Public.

Description

Adding vendor prefix to Locale class (becoming v8Locale) to minimize risk of future changes. Committed: http://code.google.com/p/v8/source/detail?r=6530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M src/extensions/experimental/i18n-extension.cc View 2 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nebojša Ćirić
To quote Oliver Hunt (Apple) on why would this be a good idea: "I'm concerned ...
9 years, 11 months ago (2011-01-28 19:08:25 UTC) #1
Nebojša Ćirić
On a webkit bug (https://bugs.webkit.org/show_bug.cgi?id=49414) thread Darin confirmed that only Locale should be prefixed with ...
9 years, 11 months ago (2011-01-28 21:33:26 UTC) #2
Mads Ager (chromium)
OK
9 years, 10 months ago (2011-01-31 09:57:18 UTC) #3
Mads Ager (chromium)
9 years, 10 months ago (2011-01-31 09:58:52 UTC) #4
Landed.

Powered by Google App Engine
This is Rietveld 408576698