BMM: Handle middle click correctly.

chrome/browser/resources/shared/js/cr/link_controller.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview This file provides a class that can be used to open URLs based
  * on user interactions. It ensures a consistent behavior when it comes to
  * holding down Ctrl and Shift while clicking or activating the a link.
  *
  * This depends on the {@code chrome.windows} and {@code chrome.tabs}
@@ skipping 64 matching lines @@
       return this.localStrings_.getStringF('should_open_all', count);
     },
 
     /**
      * Open an URL from a mouse or keyboard event.
      * @param {string} url The URL to open.
      * @param {!Event} e The event triggering the opening of the URL.
      */
     openUrlFromEvent: function(url, e) {
       // We only support keydown Enter and non right click events.
-      if (e.type == 'keydown') {
-        if(e.keyIdentifier != 'Enter')
-          return;
-      } else if (e.type != 'click' || e.button == 2) {
-        return;
+      if (e.type == 'keydown' && e.keyIdentifier == 'Enter' ||
+          e.button != 2) {
+        var kind;
+        var ctrl = cr.isMac && e.metaKey || !cr.isMac && e.ctrlKey;
+
+        if (e.button == 1 || ctrl) // middle, ctrl or keyboard
+          kind = e.shiftKey ? LinkKind.FOREGROUND_TAB : LinkKind.BACKGROUND_TAB;
+        else // left or keyboard
+          kind = e.shiftKey ? LinkKind.WINDOW : LinkKind.SELF;
+
+        this.openUrls([url], kind);
       }
-
-      var kind;
-      var ctrl = cr.isMac && e.metaKey || !cr.isMac && e.ctrlKey;
-
-      if (e.button == 1 || ctrl) // middle, ctrl or keyboard
-        kind = e.shiftKey ? LinkKind.FOREGROUND_TAB : LinkKind.BACKGROUND_TAB;
-      else // left or keyboard
-        kind = e.shiftKey ? LinkKind.WINDOW : LinkKind.SELF;
-
-      this.openUrls([url], kind);
     },
 
 
     /**
      * Opens a URL in a new tab, window or incognito window.
      * @param {string} url The URL to open.
      * @param {LinkKind} kind The kind of open we want to do.
      */
     openUrl: function (url, kind) {
       this.openUrls([url], kind);
@@ skipping 39 matching lines @@
       }
     }
   };
 
   // Export
   return {
     LinkController: LinkController,
     LinkKind: LinkKind
   };
 });