BMM: Handle middle click correctly.

chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(arv): Now that this is driven by a data model, implement a data model
 //            that handles the loading and the events from the bookmark backend.
 
 cr.define('bmm', function() {
   const List = cr.ui.List;
   const ListItem = cr.ui.ListItem;
@@ skipping 50 matching lines @@
    * @extends {HTMLButtonElement}
    */
   var BookmarkList = cr.ui.define('list');
 
   BookmarkList.prototype = {
     __proto__: List.prototype,
 
     /** @inheritDoc */
     decorate: function() {
       List.prototype.decorate.call(this);
-      this.addEventListener('click', this.handleClick_);
       this.addEventListener('mousedown', this.handleMouseDown_);
 
       // HACK(arv): http://crbug.com/40902
       window.addEventListener('resize', this.redraw.bind(this));
 
       // We could add the ContextMenuButton in the BookmarkListItem but it slows
       // down redraws a lot so we do this on mouseovers instead.
       this.addEventListener('mouseover', this.handleMouseOver_.bind(this));
     },
 
@@ skipping 101 matching lines @@
         el = el.parentNode;
       }
 
       if (el && el.parentNode == this &&
           !(el.lastChild instanceof ContextMenuButton)) {
         el.appendChild(new ContextMenuButton);
       }
     },
 
     /**
-     * Handles the clicks on the list so that we can check if the user clicked
-     * on a link or a folder.
+     * Dispatches an urlClicked event which is used to open URLs in new
+     * tabs etc.
      * @private
-     * @param {!Event} e The click event object.
+     * @param {string} url The URL that was clicked.
+     * @param {!Event} originalEvent The original click event object.
      */
-    handleClick_: function(e) {
-      // Handle middle click to open bookmark in a new tab.
-      if (e.button == 1) {
-        var el = e.target;
-        while (el.parentNode != this) {
-          el = el.parentNode;
-        }
-        var node = el.bookmarkNode;
-        if (!bmm.isFolder(node)) {
-          var event = new cr.Event('urlClicked', true, false);
-          event.url = node.url;
-          event.originalEvent = e;
-          this.dispatchEvent(event);
-        }
-      }
+    dispatchUrlClickedEvent_: function(url, originalEvent) {
+      var event = new cr.Event('urlClicked', true, false);
+      event.url = url;
+      event.originalEvent = originalEvent;
+      this.dispatchEvent(event);
     },
 
     /**
      * Handles mousedown events so that we can prevent the auto scroll as
      * necessary.
      * @private
      * @param {!MouseEvent} e The mousedown event object.
      */
     handleMouseDown_: function(e) {
       if (e.button == 1) {
@@ skipping 13 matching lines @@
 
     /**
      * WebKit no longer dispatches click events for middle clicks so we need
      * to emulate it.
      * @private
      * @param {!MouseEvent} e The mouse up event object.
      */
     handleMiddleMouseUp_: function(e) {
       this.removeEventListener('mouseup', this.handleMiddleMouseUp_);
       if (e.button == 1) {
-        var clickEvent = document.createEvent('MouseEvent');
-        clickEvent.initMouseEvent('click',
-                                  true,  // canBubble
-                                  true,  // cancelable,
-                                  e.view, e.detail,
-                                  e.screenX, e.screenY, e.clientX, e.clientY,
-                                  e.ctrlKey, e.altKey, e.shiftKey, e.metaKey,
-                                  e.button, e.relatedTarget);
-        e.target.dispatchEvent(clickEvent);
+        var el = e.target;
+        while (el.parentNode != this) {
+          el = el.parentNode;
+        }
+        var node = el.bookmarkNode;
+        if (node && !bmm.isFolder(node))
+          this.dispatchUrlClickedEvent_(node.url, e);
       }
     },
 
     // Bookmark model update callbacks
     handleBookmarkChanged: function(id, changeInfo) {
       var dataModel = this.dataModel;
       var index = dataModel.findIndexById(id);
       if (index != -1) {
         var bookmarkNode = this.dataModel.item(index);
         bookmarkNode.title = changeInfo.title;
@@ skipping 325 matching lines @@
           cr.dispatchSimpleEvent(this, 'edit', true);
         }
       }
     }
   };
 
   return {
     BookmarkList: BookmarkList
   };
 });