Issue 6332020: BMM: Handle middle click correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6332020: BMM: Handle middle click correctly. (Closed)

Created:
9 years, 11 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

BMM: Handle middle click correctly. This fixes a regression. Originally we listened to click events for middle click. The WebKit was change to not fire click events for middle clicks so I added code to work around that. The WebKit change caused a lot of regressions and was reverted. Now the BMM opened 2 background tabs (one for click and one for the work around). With this change I no longer listen to click and only do the work around. BUG=70929 TEST=Open bookmark manager. Middle click on a bookmark. Only one background tab should be opened. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72843

Patch Set 1 #

Patch Set 2 : Fix typo #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -42 lines)			Patch
	M	chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js	View	1	3 chunks	+16 lines, -28 lines	0 comments	Download
	M	chrome/browser/resources/shared/js/cr/link_controller.js	View		1 chunk	+10 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2011/01/27 18:26:58, arv wrote:

LGTM.

Expand Messages | Collapse Messages