Issue 6332013: views: Forward declare "class View;" in layout_manager.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6332013: views: Forward declare "class View;" in layout_manager.h (Closed)

Created:
9 years, 11 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

views: Forward declare "class View;" in layout_manager.h And move the include of views/view.h from the header to the source file. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72587

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -7 lines)			Patch
M	chrome/browser/ui/views/frame/browser_view_layout.h	View	1 2 3 4 5	4 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout.cc	View	1 2 3 4 5	2 chunks	+5 lines, -0 lines	0 comments	Download
M	views/layout/box_layout.h	View	1 2	2 chunks	+10 lines, -3 lines	0 comments	Download
M	views/layout/box_layout.cc	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	views/layout/layout_manager.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	views/layout/layout_manager.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/widget/widget_win.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

tfarina

Scott, this is ready for review. (I'll fix any other trybots errors if they appear). ...

9 years, 11 months ago (2011-01-25 21:53:53 UTC) #1

LGTM