Issue 6332012: Re-submitting the cl r72292, while removing incorrect DCHECK()...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6332012: Re-submitting the cl r72292, while removing incorrect DCHECK()... (Closed)

Created:
9 years, 11 months ago by GeorgeY

Modified:
9 years, 6 months ago

Reviewers:
Ilya Sherman, dhollowa

CC:
chromium-reviews, Ilya Sherman, Paweł Hajdan Jr., James Hawkins, dhollowa

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Re-submitting the cl r72292, while removing incorrect DCHECK() Propagate correct data to the Toolbar servers BUG=67219 TEST=unit-tested Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72523

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+285 lines, -47 lines)			Patch
M	chrome/browser/autofill/form_structure.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/form_structure.cc	View	6 chunks	+59 lines, -20 lines	0 comments	Download
M	chrome/browser/autofill/form_structure_unittest.cc	View	4 chunks	+221 lines, -25 lines	0 comments	Download

Total messages: 3 (0 generated)

Ilya Sherman

+David I would prefer to change the unit tests if possible, as this seems like ...

9 years, 11 months ago (2011-01-25 01:10:18 UTC) #2

dhollowa

9 years, 11 months ago (2011-01-25 01:54:45 UTC) #3

LGTM.  George please re-introduce DCHECKs and fixes for unit tests in a separate
CL.  Thanks.