chrome/test/data/extensions/subscribe_page_action/subscribe.js - Issue 6332008: The RSS subscribe.js should not double-decoded the URL passed in....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/subscribe_page_action/subscribe.js

Issue 6332008: The RSS subscribe.js should not double-decoded the URL passed in.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/extensions/subscribe_page_action/subscribe.js

===================================================================

--- chrome/test/data/extensions/subscribe_page_action/subscribe.js (revision 71771)

+++ chrome/test/data/extensions/subscribe_page_action/subscribe.js (working copy)

@@ -39,7 +39,7 @@

var select = document.getElementById('readerDropdown');

var url =

feedReaderList[select.selectedIndex].url.replace(

- "%s", escape(encodeURI(feedUrl)));

+ "%s", encodeURIComponent(feedUrl));

// Before we navigate, see if we want to skip this step in the future...

if (storageEnabled) {

@@ -105,7 +105,6 @@

"'></" + "script>";

}

- feedUrl = decodeURIComponent(feedUrl);

req.onload = handleResponse;

req.onerror = handleError;

// Not everyone sets the mime type correctly, which causes handleResponse