The RSS subscribe.js should not double-decoded the URL passed in....

chrome/test/data/extensions/subscribe_page_action/subscribe.js

Index: chrome/test/data/extensions/subscribe_page_action/subscribe.js
===================================================================
--- chrome/test/data/extensions/subscribe_page_action/subscribe.js	(revision 71771)
+++ chrome/test/data/extensions/subscribe_page_action/subscribe.js	(working copy)
@@ -39,7 +39,7 @@
   var select = document.getElementById('readerDropdown');
   var url =
       feedReaderList[select.selectedIndex].url.replace(
-          "%s", escape(encodeURI(feedUrl)));

[Aaron Boodman, 2011/01/20 17:47:15]

escape and encodeURI do subtlety different things. There is also
encodeURIComponent(). Which one do you want here? I sort of think you probably
want encodeURIComponent().

+          "%s", escape(feedUrl));
 
   // Before we navigate, see if we want to skip this step in the future...
   if (storageEnabled) {
@@ -105,7 +105,6 @@
                     "'></" + "script>";
   }
 
-  feedUrl = decodeURIComponent(feedUrl);
   req.onload = handleResponse;
   req.onerror = handleError;
   // Not everyone sets the mime type correctly, which causes handleResponse