Issue 6332006: DOMUI Prefs: Improve saving of homepage pref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6332006: DOMUI Prefs: Improve saving of homepage pref. (Closed)

Created:
9 years, 11 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI Prefs: Improve saving of homepage pref. - Adds oninput handling to live-save the homepage pref. I had avoided this before because I didn't want to pollute metrics, but this pref doesn't actually have a metric. (Also, if one is added, we can increment it only on the onchange events.) - Does URL fixup for onchange events (not oninput, because it would make typing impossible). BUG=69901, 62851 TEST=Change the homepage to a non-canonical URL; it should be updated on blur to a full URL. On ChromeOS, power off the machine after changing the home page, but not blurring the field; it should be saved. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71835

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -6 lines)			Patch
M	chrome/browser/dom_ui/options/browser_options_handler.h	View	3 chunks	+7 lines, -0 lines	1 comment	Download
M	chrome/browser/dom_ui/options/browser_options_handler.cc	View	4 chunks	+26 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/browser_options.js	View	2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

csilv

9 years, 11 months ago (2011-01-19 18:42:25 UTC) #2

LGTM

http://codereview.chromium.org/6332006/diff/1/chrome/browser/dom_ui/options/b...
File chrome/browser/dom_ui/options/browser_options_handler.h (right):

http://codereview.chromium.org/6332006/diff/1/chrome/browser/dom_ui/options/b...
chrome/browser/dom_ui/options/browser_options_handler.h:1: // Copyright (c) 2010
The Chromium Authors. All rights reserved.
bump to 2011, here and other files

Expand Messages | Collapse Messages