Issue 6332004: Initialized 3 boolean variables....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6332004: Initialized 3 boolean variables.... (Closed)

Created:
9 years, 11 months ago by asharif1

Modified:
9 years, 6 months ago

Reviewers:
mattm

CC:
chromium-reviews, bjanakiraman1

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Initialized 3 boolean variables. The compiler gives an uninitialized variable warning when CallbackArgsToBool() is inlined. BUG=none TEST=Trivial fix. Patch from <asharif@chromium.org>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71748

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/dom_ui/options/certificate_manager_handler.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

asharif1

Please review this. These variables are a copy of another set of variables I initialized ...

9 years, 11 months ago (2011-01-18 19:12:16 UTC) #1

asharif1

9 years, 11 months ago (2011-01-18 23:44:48 UTC) #3

On 2011/01/18 22:29:36, mattm wrote:
> lgtm

Sorry I forgot to mention this: I am not a committer so you'll have to push this
CL.

Thanks,