Issue 6332002: AU: Add more signing unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6332002: AU: Add more signing unit tests. (Closed)

Created:
9 years, 11 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git@master

Visibility:
Public.

Description

AU: Add more signing unit tests. 1. Test generating/applying unsigned payloads. 2. Test signing/verifying generated payloads through shell commands. BUG=chromium-os:10936 TEST=unit tests Change-Id: Ibb115207d563f4c871121c5deec2477857a93e20 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cbfb017

Patch Set 1 #

Patch Set 2 : fix build #

Total comments: 2

Patch Set 3 : review comments #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -55 lines)			Patch
	M	delta_performer_unittest.cc	View	1 2	7 chunks	+123 lines, -55 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ nit http://codereview.chromium.org/6332002/diff/2001/delta_performer_unittest.cc File delta_performer_unittest.cc (right): http://codereview.chromium.org/6332002/diff/2001/delta_performer_unittest.cc#newcode105 delta_performer_unittest.cc:105: int GetSignatureSize() { this should return ...

9 years, 11 months ago (2011-01-14 01:15:11 UTC) #2

petkov

9 years, 11 months ago (2011-01-14 18:04:13 UTC) #3

thanks, i'll push after you review the ebuild change.

http://codereview.chromium.org/6332002/diff/2001/delta_performer_unittest.cc
File delta_performer_unittest.cc (right):

http://codereview.chromium.org/6332002/diff/2001/delta_performer_unittest.cc#...
delta_performer_unittest.cc:105: int GetSignatureSize() {
On 2011/01/14 01:15:11, adlr wrote:
> this should return a size_t right?

sure, why not. it doesn't matter much though in this case.

> 
> You also checked in similar code just recently right? Maybe merge?

I believe that's the code I checked in recently and this patch refactors it into
a separate routine so that it can be reused in tests.

Expand Messages | Collapse Messages