Issue 6331009: Remove the check for the obsolete CERT_TRUST_IS_NOT_TIME_NESTED...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6331009: Remove the check for the obsolete CERT_TRUST_IS_NOT_TIME_NESTED... (Closed)

Created:
9 years, 11 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove the check for the obsolete CERT_TRUST_IS_NOT_TIME_NESTED error status. CertGetCertificateChain no longer detects the error. R=agl BUG=70210 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72159

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improve comment as agl suggested #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	net/base/x509_certificate_win.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

9 years, 11 months ago (2011-01-21 16:47:47 UTC) #2

LGTM

http://codereview.chromium.org/6331009/diff/1/net/base/x509_certificate_win.cc
File net/base/x509_certificate_win.cc (right):

http://codereview.chromium.org/6331009/diff/1/net/base/x509_certificate_win.c...
net/base/x509_certificate_win.cc:96: // CERT_TRUST_IS_NOT_TIME_NESTED is
obsolete, but we don't consider it an
This would make me look for it in the code. Maybe

"We don't include CERT_TRUST_IS_NOT_TIME_NESTED because it's obsolete and we
wouldn't consider it an error anyway".

Expand Messages | Collapse Messages