Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: depot_tools/git_cl/git_cl.py

Issue 6331008: Tweak an informative message that has mislead at least 3 people so far. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: depot_tools/git_cl/git_cl.py
===================================================================
--- depot_tools/git_cl/git_cl.py (revision 71892)
+++ depot_tools/git_cl/git_cl.py (working copy)
@@ -1029,8 +1029,14 @@
def CMDdcommit(parser, args):
"""commit the current changelist via git-svn"""
if not settings.GetIsGitSvn():
- print('This doesn\'t appear to be an SVN repository.')
- print('Are you sure you didn\'t mean \'git cl push\'?')
+ message = """This doesn't appear to be an SVN repository.
+If your project has a git mirror with an upstream SVN master, you probably need
+to run 'git svn init', see your project's git mirror documentation.
+If your project has a true writeable upstream repository, you probably want
+to run 'git cl push' instead.
+Choose wisely, if you get this wrong, your commit might appear to succeed but
+will instead be silently ignored."""
+ print(message)
raw_input('[Press enter to dcommit or ctrl-C to quit]')
return SendUpstream(parser, args, 'dcommit')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698