Issue 6331007: Use different proxy ports, and log port conflicts. Hopefully works around

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6331007: Use different proxy ports, and log port conflicts. Hopefully works around (Closed)

Created:
9 years, 11 months ago by dgarrett

Modified:
9 years, 7 months ago

Reviewers:
thieule, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Use different proxy ports, and log port conflicts. Hopefully works around build problems, and will give better diagnostics if not. Change-Id: I2f7a5d9b2e0c63a8189ad212125c7a5c0178c3c4 BUG=10567 TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e70ccb9

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	bin/cros_au_test_harness.py	View		3 chunks	+5 lines, -6 lines	0 comments	Download
	M	lib/cros_test_proxy.py	View		1 chunk	+8 lines, -3 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

9 years, 11 months ago (2011-01-19 20:07:54 UTC) #2

Thanks!

LGTM w/ cpl nits

http://codereview.chromium.org/6331007/diff/1/lib/cros_test_proxy.py
File lib/cros_test_proxy.py (right):

http://codereview.chromium.org/6331007/diff/1/lib/cros_test_proxy.py#newcode108
lib/cros_test_proxy.py:108: import os
please import os at the top

http://codereview.chromium.org/6331007/diff/1/lib/cros_test_proxy.py#newcode109
lib/cros_test_proxy.py:109: os.system("sudo netstat -l --tcp -n -p")
use '' rather than "" to be consistent.

Expand Messages | Collapse Messages