Issue 6331006: Make the code for unmaximizing the window during SetBounds much simpler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6331006: Make the code for unmaximizing the window during SetBounds much simpler. (Closed)

Created:
9 years, 11 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make the code for unmaximizing the window during SetBounds much simpler. This still fixes the original bug and does it in a much simpler (and faster) way. I was previously attempting to use an API to do this rather than just setting the style directly but that API may have hidden side effects like causing a window activation on some versions of Windows. BUG=69724 TEST=WidgetWinTest::SetBoundsForZoomedWindow Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71767

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	views/widget/widget_win.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	views/widget/widget_win_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 11 months ago (2011-01-18 23:16:34 UTC) #2

Does this fix the Win7 bug that Anthony assigned you earlier too?

LGTM anyway.

Expand Messages | Collapse Messages