Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3126)

Unified Diff: chrome/test/webdriver/automation.h

Issue 6330012: Cookie commands for the webdriver protocol (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: dsdsdsdjsdsj Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/automation.h
diff --git a/chrome/test/webdriver/automation.h b/chrome/test/webdriver/automation.h
index 10ab4a1340c54134aeb5acde961a8488d55939ef..386ef9b3c0b62d6c6417deedbfc83eb2e3c47d3c 100644
--- a/chrome/test/webdriver/automation.h
+++ b/chrome/test/webdriver/automation.h
@@ -42,7 +42,14 @@ class Automation : private UITestBase {
void GoBack(bool* success);
void Reload(bool* success);
void GetURL(std::string* url, bool* success);
+ void GetGURL(GURL* gurl, bool* success);
void GetTabTitle(std::string* tab_title, bool* success);
+ void GetCookies(const GURL& gurl, std::string* cookies, bool* success);
John Grabowski 2011/02/14 21:59:06 Why don't you like return values? Seems you could
kkania 2011/02/14 22:47:08 We don't return bool because these methods are cal
John Grabowski 2011/02/14 22:57:09 Seems completely reasonable. How about a comment a
+ void GetCookieByName(const GURL& gurl, const std::string& cookie_name,
+ std::string* cookie, bool* success);
+ void DeleteCookie(const GURL& gurl, const std::string& cookie_name,
+ bool* success);
+ void SetCookie(const GURL& gurl, const std::string& cookie, bool* success);
private:
scoped_refptr<BrowserProxy> browser_;

Powered by Google App Engine
This is Rietveld 408576698