Cookie commands for the webdriver protocol

chrome/test/webdriver/cookie.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#pragma once

[kkania, 2011/02/08 18:35:22]

#pragma goes after the #define

[Joe, 2011/02/09 06:32:10]

Done.

+#ifndef CHROME_TEST_WEBDRIVER_COOKIE_H_
+#define CHROME_TEST_WEBDRIVER_COOKIE_H_
+
+#include <string>

[kkania, 2011/02/08 18:35:22]

newline after

[Joe, 2011/02/09 06:32:10]

Done.

+#include "base/values.h"

[kkania, 2011/02/08 18:35:22]

change this to "class DictionaryValue;" and move the #include "base/values.h"
inside of cookie.cc

[Joe, 2011/02/09 06:32:10]

Done.

+
+namespace webdriver {
+
+// Class used to conveniently convert cookies to various formats.

[kkania, 2011/02/08 18:35:22]

drop 'conveniently'

[Joe, 2011/02/09 06:32:10]

Done.

+class Cookie {
+ public:
+  explicit Cookie(const std::string& cookie);
+  explicit Cookie(const DictionaryValue& dict);
+
+  DictionaryValue* ToJSON();

[kkania, 2011/02/08 18:35:22]

change ToJSON -> ToDictionary

[Joe, 2011/02/09 06:32:10]

Done.

[Joe, 2011/02/09 06:32:10]

Done.

+  std::string ToJSONString();
+  std::string ToString();
+
+  bool IsValid() { return valid_; }

[kkania, 2011/02/08 18:35:22]

bool IsValid() const {

[Joe, 2011/02/09 06:32:10]

Done.

+  const std::string get_name() { return name_; }

[kkania, 2011/02/08 18:35:22]

std::string get_name() const {

[Joe, 2011/02/09 06:32:10]

Done.

[Joe, 2011/02/09 06:32:10]

Done.

+
+ private:
+  std::string name_;
+  std::string value_;
+  std::string path_;
+  std::string domain_;
+  std::string expires_;
+  bool secure_;
+  bool http_;
+  bool valid_;
+
+  DISALLOW_COPY_AND_ASSIGN(Cookie);
+};
+
+}  // namespace webdriver
+
+#endif  // CHROME_TEST_WEBDRIVER_COOKIE_H_