Cookie commands for the webdriver protocol

chrome/test/webdriver/commands/cookie_commands.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#pragma once

[kkania, 2011/02/08 18:35:22]

this should go after the #define statement

[Joe, 2011/02/09 06:32:10]

Done.

+#ifndef CHROME_TEST_WEBDRIVER_COMMANDS_COOKIE_COMMANDS_H_
+#define CHROME_TEST_WEBDRIVER_COMMANDS_COOKIE_COMMANDS_H_
+
+#include <string>
+
+#include "googleurl/src/gurl.h"

[kkania, 2011/02/08 18:35:22]

wrong order, do this:
#include "chrome/test/webdriver/commands/webdriver_command.h"
#include "googleurl/src/gurl.h"

[Joe, 2011/02/09 06:32:10]

Done.

+
+#include "chrome/test/webdriver/commands/webdriver_command.h"
+

[kkania, 2011/02/08 18:35:22]

you need to add:
class DictionaryValue;

+namespace webdriver {

[kkania, 2011/02/08 18:35:22]

you need to add:
class Response;

[Joe, 2011/02/09 06:32:10]

Done.

+
+// Retrieve all cookies visible to the current page. Each cookie will be
+// returned as a JSON object with the following properties:
+// name, value, path, domain, secure, and expiry. See:
+// http://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/cookie
+class CookieCommand: public WebDriverCommand {
+ public:
+   CookieCommand(const std::vector<std::string> path_segments,

[kkania, 2011/02/08 18:35:22]

don't forget the &

[Joe, 2011/02/09 06:32:10]

This would break because it doesn't match the base class

On 2011/02/08 18:35:22, kkania wrote:

+                 const DictionaryValue* const parameters)
+      : WebDriverCommand(path_segments, parameters) {}
+  virtual ~CookieCommand(){}
+
+  virtual bool Init(Response* const response);
+
+  virtual bool DoesDelete() { return true; }
+  virtual bool DoesGet() { return true; }
+  virtual bool DoesPost() { return true; }
+
+  virtual void ExecuteDelete(Response* const response);
+  virtual void ExecuteGet(Response* const response);
+  virtual void ExecutePost(Response* const response);
+
+ private:
+  GURL current_url_;
+
+  virtual bool RequiresValidTab() { return true; }

[kkania, 2011/02/08 18:35:22]

RequiresValidTab is no longer used; remove

[Joe, 2011/02/09 06:32:10]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(CookieCommand);
+};
+
+// Set a cookie. The cookie should be specified as a JSON object with the
+// following properties: name, value, path, domain, secure, and expiry. See:
+// http://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/cookie/:name
+class NamedCookieCommand : public WebDriverCommand {
+ public:
+   NamedCookieCommand(const std::vector<std::string> path_segments,

[kkania, 2011/02/08 18:35:22]

don't forget the &

[Joe, 2011/02/09 06:32:10]

This would break because it doesn't match the base class
On 2011/02/08 18:35:22, kkania wrote:

+                      const DictionaryValue* const parameters)
+      : WebDriverCommand(path_segments, parameters) {}
+  virtual ~NamedCookieCommand(){}
+
+  virtual bool Init(Response* const response);
+
+ protected:
+  virtual bool DoesDelete() { return true; }
+  virtual bool DoesGet() { return true; }
+
+  virtual void ExecuteDelete(Response* const response);
+  virtual void ExecuteGet(Response* const response);
+
+ private:
+  GURL current_url_;
+  std::string cookie_name_;
+
+  virtual bool RequiresValidTab() { return true; }

[kkania, 2011/02/08 18:35:22]

RequiresValidTab is no longer used; remove

[Joe, 2011/02/09 06:32:10]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(NamedCookieCommand);
+};
+
+}  // namespace webdriver
+
+#endif  // CHROME_TEST_WEBDRIVER_COMMANDS_COOKIE_COMMANDS_H_
+