Cookie commands for the webdriver protocol

chrome/test/webdriver/commands/cookie_commands.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#pragma once

[kkania, 2011/02/04 17:04:44]

put this after the #define CHROME_TEST....

[Joe, 2011/02/09 06:32:10]

If you place it after the ifdef doesn't that defeat the purpose of having it? 
From my understanding it's supposed to be an more efficient version of using
ifdef.

http://en.wikipedia.org/wiki/Pragma_once

On 2011/02/04 17:04:44, kkania wrote:

+#ifndef CHROME_TEST_WEBDRIVER_COMMANDS_COOKIE_COMMANDS_H_
+#define CHROME_TEST_WEBDRIVER_COMMANDS_COOKIE_COMMANDS_H_
+
+#include "chrome/test/webdriver/commands/webdriver_command.h"
+
+namespace webdriver {
+
+// Retrieve all cookies visible to the current page. Each cookie will be
+// returned as a JSON object with the following properties:
+// name, value, path, domain, secure, and expiry. See:
+// http://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/cookie
+class CookieCommand: public WebDriverCommand {

[John Grabowski, 2011/02/04 02:40:23]

Here you have
  class CookieCommand:
later in this file you have
  class NamedCookieCommand :   (space between the name and :)

I like the 2nd one better, but you should maintain consistency with the other
commands (and within the same file).

[Joe, 2011/02/09 06:32:10]

I named the classes after the URLS of the JSON webdriver protocol.  In the cases
of cookies there are actually 2 URLS.
/session/:sessionId/cookie
/session/:sessionId/cookie/:name

On 2011/02/04 02:40:23, John Grabowski wrote:

+ public:
+   CookieCommand(const std::vector<std::string> path_segments,
+                 const DictionaryValue* const parameters)
+      : WebDriverCommand(path_segments, parameters) {}
+  virtual ~CookieCommand(){}
+
+  virtual bool Init(Response* const response);
+
+  virtual bool DoesDelete() { return true; }
+  virtual bool DoesGet() { return true; }
+  virtual bool DoesPost() { return true; }
+
+  virtual void ExecuteDelete(Response* const response);
+  virtual void ExecuteGet(Response* const response);
+  virtual void ExecutePost(Response* const response);
+
+ private:
+  GURL current_url_;

[kkania, 2011/02/04 17:04:44]

need to include GURL header in this file since you have this here

[Joe, 2011/02/09 06:32:10]

Done.

+
+  virtual bool RequiresValidTab() { return true; }
+
+  DISALLOW_COPY_AND_ASSIGN(CookieCommand);
+};
+
+// Set a cookie. The cookie should be specified as a JSON object with the
+// following properties: name, value, path, domain, secure, and expiry. See:
+// http://code.google.com/p/selenium/wiki/JsonWireProtocol#/session/:sessionId/cookie/:name
+class NamedCookieCommand : public WebDriverCommand {
+ public:
+   NamedCookieCommand(const std::vector<std::string> path_segments,
+                      const DictionaryValue* const parameters)
+      : WebDriverCommand(path_segments, parameters) {}
+  virtual ~NamedCookieCommand(){}
+
+  virtual bool Init(Response* const response);
+
+ protected:
+  virtual bool DoesDelete() { return true; }
+  virtual bool DoesGet() { return true; }
+
+  virtual void ExecuteDelete(Response* const response);
+  virtual void ExecuteGet(Response* const response);
+
+ private:
+  GURL current_url_;
+  std::string cookie_name_;

[kkania, 2011/02/04 17:04:44]

need to #include <string>

[Joe, 2011/02/09 06:32:10]

Done.

+
+  virtual bool RequiresValidTab() { return true; }
+
+  DISALLOW_COPY_AND_ASSIGN(NamedCookieCommand);
+};
+
+}  // namespace webdriver
+
+#endif  // CHROME_TEST_WEBDRIVER_COMMANDS_COOKIE_COMMANDS_H_
+