Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/test/webdriver/commands/command.h" | 5 #include "chrome/test/webdriver/commands/command.h" |
| 6 | 6 |
| 7 namespace webdriver { | 7 namespace webdriver { |
| 8 | 8 |
| 9 // Error message taken from: | 9 // Error message taken from: |
| 10 // http://code.google.com/p/selenium/wiki/JsonWireProtocol#Response_Status_Codes | 10 // http://code.google.com/p/selenium/wiki/JsonWireProtocol#Response_Status_Codes |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 30 bool Command::GetBooleanParameter(const std::string& key, | 30 bool Command::GetBooleanParameter(const std::string& key, |
| 31 bool* out) const { | 31 bool* out) const { |
| 32 return parameters_.get() != NULL && parameters_->GetBoolean(key, out); | 32 return parameters_.get() != NULL && parameters_->GetBoolean(key, out); |
| 33 } | 33 } |
| 34 | 34 |
| 35 bool Command::GetIntegerParameter(const std::string& key, | 35 bool Command::GetIntegerParameter(const std::string& key, |
| 36 int* out) const { | 36 int* out) const { |
| 37 return parameters_.get() != NULL && parameters_->GetInteger(key, out); | 37 return parameters_.get() != NULL && parameters_->GetInteger(key, out); |
| 38 } | 38 } |
| 39 | 39 |
| 40 bool Command::GetDictionaryParameter(const std::string& key, | |
|
kkania
2011/01/28 23:25:59
can we just get rid of these functions and let par
Joe
2011/02/03 10:02:05
It was like that in the original version but Jason
| |
| 41 DictionaryValue** out) const { | |
| 42 return parameters_.get() != NULL && parameters_->GetDictionary(key, out); | |
| 43 } | |
| 44 | |
| 40 } // namespace webdriver | 45 } // namespace webdriver |
| 41 | 46 |
| OLD | NEW |