Issue 6330010: Prevent extensions from moving tabs between profiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6330010: Prevent extensions from moving tabs between profiles. (Closed)

Created:
9 years, 11 months ago by jstritar

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Prevent extensions from moving tabs between profiles. BUG=69285 TEST=ExtensionApiTest.Incognito Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72652

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
M	chrome/browser/extensions/extension_tabs_module.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module_constants.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/incognito/apis/background.html	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

9 years, 11 months ago (2011-01-25 23:13:21 UTC) #2

lgtm

http://codereview.chromium.org/6330010/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tabs_module_constants.cc (right):

http://codereview.chromium.org/6330010/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tabs_module_constants.cc:57: const char
kCanOnlyMoveTabsWithinSameProfileError[] = "Tabs can only be moved "
Nit: s/to and from/between

Expand Messages | Collapse Messages