Issue 633001: fixup autoupdate for new build system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 633001: fixup autoupdate for new build system (Closed)

Created:
10 years, 10 months ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

fixup autoupdate for new build system - write board is to /etc/lsb-release - send board id to omaha - require board to find latest image

Patch Set 2 : per review comments #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -54 lines)			Patch
M	src/platform/dev/autoupdate.py	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/platform/memento_softwareupdate/ping_omaha.sh	View	1	5 chunks	+17 lines, -8 lines	0 comments	Download
M	src/scripts/build_autotest.sh	View		2 chunks	+53 lines, -42 lines	0 comments	Download
M	src/scripts/get_latest_image.sh	View		1 chunk	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adlr

http://codereview.chromium.org/633001/diff/1/3 File src/platform/memento_softwareupdate/ping_omaha.sh (right): http://codereview.chromium.org/633001/diff/1/3#newcode79 src/platform/memento_softwareupdate/ping_omaha.sh:79: v=$(grep ^CHROMEOS_RELEASE_TRACK $dir/etc/lsb-release | \ use non-single letter variables, ...

10 years, 10 months ago (2010-02-17 23:47:45 UTC) #2

Sam Leffler

10 years, 10 months ago (2010-02-18 00:12:07 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 633001: fixup autoupdate for new build system (Closed)

Description

Patch Set 1 #

Patch Set 2 : per review comments #

Messages