Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: chrome/browser/renderer_host/render_widget_helper.cc

Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_helper.cc
diff --git a/chrome/browser/renderer_host/render_widget_helper.cc b/chrome/browser/renderer_host/render_widget_helper.cc
index 3176027c745c98f21357155c5fe731d864ea7727..d94ae33bacf4b7ae7ed0f735a438745ccb5ea652 100644
--- a/chrome/browser/renderer_host/render_widget_helper.cc
+++ b/chrome/browser/renderer_host/render_widget_helper.cc
@@ -9,9 +9,7 @@
#include "chrome/browser/browser_thread.h"
#include "chrome/browser/renderer_host/render_process_host.h"
#include "chrome/browser/renderer_host/render_view_host.h"
-#include "chrome/browser/renderer_host/render_view_host_delegate.h"
#include "chrome/browser/renderer_host/resource_dispatcher_host.h"
-#include "chrome/common/notification_service.h"
#include "chrome/common/render_messages_params.h"
// A Task used with InvokeLater that we hold a pointer to in pending_paints_.
@@ -222,18 +220,8 @@ void RenderWidgetHelper::OnCreateWindowOnUI(
int route_id) {
RenderViewHost* host =
RenderViewHost::FromID(render_process_id_, params.opener_id);
- if (host) {
- host->CreateNewWindow(route_id,
- params.window_container_type,
- params.frame_name);
- TabContents* tab_contents = host->delegate()->GetAsTabContents();
- if (tab_contents) {
- NotificationService::current()->Notify(
- NotificationType::CREATING_NEW_WINDOW,
- Source<TabContents>(tab_contents),
- Details<const ViewHostMsg_CreateWindow_Params>(&params));
- }
- }
+ if (host)
+ host->CreateNewWindow(route_id, params);
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
« no previous file with comments | « chrome/browser/renderer_host/render_view_host_delegate.h ('k') | chrome/browser/tab_contents/background_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698