Issue 6330005: [gtk] Don't show empty status bubble in kiosk mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6330005: [gtk] Don't show empty status bubble in kiosk mode. (Closed)

Created:
9 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[gtk] Don't show empty status bubble in kiosk mode. BUG=67956 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71858

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/gtk/status_bubble_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

9 years, 11 months ago (2011-01-19 18:54:30 UTC) #2

LGTM
On Jan 18, 2011 3:33 PM, <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> [gtk] Don't show empty status bubble in kiosk mode.
>
> BUG=67956
> TEST=manual
>
> Please review this at http://codereview.chromium.org/6330005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M chrome/browser/ui/gtk/status_bubble_gtk.cc
>
>
> Index: chrome/browser/ui/gtk/status_bubble_gtk.cc
> diff --git a/chrome/browser/ui/gtk/status_bubble_gtk.cc
> b/chrome/browser/ui/gtk/status_bubble_gtk.cc
> index
>
48557e01d328c2928d1bdf8ae945e71218d9e4aa..1069334bbff4026b8ca661f7c40255b5ffcd6ca9

> 100644
> --- a/chrome/browser/ui/gtk/status_bubble_gtk.cc
> +++ b/chrome/browser/ui/gtk/status_bubble_gtk.cc
> @@ -255,6 +255,7 @@ void StatusBubbleGtk::InitWidgets() {
> gtk_container_add(GTK_CONTAINER(padding_), label_);
>
> container_.Own(gtk_event_box_new());
> + gtk_widget_set_no_show_all(container_.get(), TRUE);
> gtk_util::ActAsRoundedWindow(
> container_.get(), gtk_util::kGdkWhite, kCornerSize,
> gtk_util::ROUNDED_TOP_RIGHT,
>
>

Expand Messages | Collapse Messages