Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3105)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/compiler_specific.h

Issue 6329027: Disable OVERRIDE for clang for a while. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/testing
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/compiler_specific.h
diff --git a/base/compiler_specific.h b/base/compiler_specific.h
index 017b8691ed9a715e4e17dcb5395198daf6fe0e0d..fd2b083f1b7c4b8e45ad79a559a058e9b1cd62be 100644
--- a/base/compiler_specific.h
+++ b/base/compiler_specific.h
@@ -84,8 +84,9 @@
// virtual void foo() OVERRIDE;
#if defined(COMPILER_MSVC)
#define OVERRIDE override
-#elif defined(__clang__)
-#define OVERRIDE __attribute__((override))
+// TODO(thakis): Reenable this, http://crbug.com/71088
+//#elif defined(__clang__)
+//#define OVERRIDE __attribute__((override))
#else
#define OVERRIDE
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698