Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 6329019: Use QuitTask instead of Quit() to signal request completion. (Closed)

Created:
9 years, 11 months ago by Satish
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Use QuitTask instead of Quit() to signal request completion. This allows for cases where the request complete callback is invoked outside a message loop, for e.g. in TestPostChunkedDataAfterStart(). Quit() can only be invoked inside a message loop whereas posting a QuitTask to the message loop can be done from anywhere. BUG=none TEST=TestPostChunkedDataAfterStart passes through the tsan bots and net_unittests in general runs fine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72493

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/url_request/url_request_unittest.h View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
Satish
9 years, 11 months ago (2011-01-25 15:30:41 UTC) #1
wtc
LGTM. Please use "svn blame" to find out who wrote the code you modified, and ...
9 years, 11 months ago (2011-01-25 15:46:43 UTC) #2
Satish
9 years, 11 months ago (2011-01-25 16:14:29 UTC) #3
Thanks, submitted.

> LGTM.  Please use "svn blame" to find out who wrote the
> code you modified, and ask him for a second review.  You
> can check this in first, with the suggested change below.

"git blame" shows that that code was part of the initial commit, so I presume we
don't have a real person's name associated with it?

Powered by Google App Engine
This is Rietveld 408576698