Screen Locker fixes

* Set the color of all state of signout button white
* Tab/alt-tab should cycle over to first/last focusable item.
  This wasn't working because views framework cannot handle
  views under TYPE_CHILD correctly. This is a hack to workaround this
  issue until DOMUI  login is ready.
* Fix callback names that were changed/removed in refactoring.

BUG=chromium-os:9889, chromium-os:9845, chromium-os:10655
TEST=manual.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72379

[whywhat, 2011-01-24 19:27:55]

LGTM

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screen_locker.cc (right):

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_locker.cc:328: // the limitatino that a
focus manager cannot handle views in
nit: limitatino -> limitation

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_locker.cc:329: // TYPE_CHILD WidgetGtk
correctly.
Should we report a bug about that? Is there one already?

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_locker.cc:337: if (reverse &&
signout_link_->HasFocus()) {
Will pressing Tab cycle through the links? As I read it, it doesn't

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/view...
File chrome/browser/chromeos/view_ids.h (right):

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/view...
chrome/browser/chromeos/view_ids.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
2010 -> 2011? Or did we decide to drop updating copyright date at some point?

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/view...
chrome/browser/chromeos/view_ids.h:14: // collison.
nit: collison -> collision

[oshima, 2011-01-24 20:24:31]

m

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screen_locker.cc (right):

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_locker.cc:328: // the limitatino that a
focus manager cannot handle views in
On 2011/01/24 19:27:56, whywhat wrote:
> nit: limitatino -> limitation

Done.

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_locker.cc:329: // TYPE_CHILD WidgetGtk
correctly.
On 2011/01/24 19:27:56, whywhat wrote:
> Should we report a bug about that? Is there one already?

I believe this is by design. I'll task to Jay about this, but since we're moving
towards DOMUI and getting this work correctly with Widget is very tricky (as
they're different views hierachy), it may not worth it.

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screen_locker.cc:337: if (reverse &&
signout_link_->HasFocus()) {
On 2011/01/24 19:27:56, whywhat wrote:
> Will pressing Tab cycle through the links? As I read it, it doesn't

It moves focus to shutdown if you press shift-tab when focus is on link.

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/view...
File chrome/browser/chromeos/view_ids.h (right):

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/view...
chrome/browser/chromeos/view_ids.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
On 2011/01/24 19:27:56, whywhat wrote:
> 2010 -> 2011? Or did we decide to drop updating copyright date at some point?

Done.

http://codereview.chromium.org/6329016/diff/2001/chrome/browser/chromeos/view...
chrome/browser/chromeos/view_ids.h:14: // collison.
On 2011/01/24 19:27:56, whywhat wrote:
> nit: collison -> collision

Done.

[oshima, 2011-01-24 20:24:31]

m