Issue 6329005: * Add WebPreference::interactive_form_validation_enabled...

Issue 6329005: * Add WebPreference::interactive_form_validation_enabled... (Closed)

Created:
9 years, 11 months ago by tkent

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), dglazkov

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

* Add WebPreference::interactive_form_validation_enabled The default value is true. * Add --disable-interactive-form-validation flag and about:flags interface The interactive form validation feature might cause web site compatibility issues. So we provide a way to disable it just in case. BUG=45804, 54368 TEST=manual; Open the URL "data:text/html,<form><input required></form>", click the input field, and press ENTER key. - A validation message is shown by default - If you run Chrome with --disable-interactive-form-validation, no validation message is shown and the form is submitted. - If you enable "Disable HTML5 interacrive form validation" flag on about:flags, no validation message is shown and the form is submitted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71902

Patch Set 1 : '' #

Total comments: 4

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -4 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	2 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+4 lines, -0 lines	2 comments	Download
M	chrome/common/render_messages.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/webpreferences.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM w/ nits fixed http://codereview.chromium.org/6329005/diff/15002/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/6329005/diff/15002/chrome/common/chrome_switches.cc#newcode243 chrome/common/chrome_switches.cc:243: const char kDisableInteractiveFormValidation[] = nit: ...

9 years, 11 months ago (2011-01-19 23:34:26 UTC) #2

tkent

9 years, 11 months ago (2011-01-20 01:40:34 UTC) #3

Thank you for reviewing.
I'll commit with the fixes.

http://codereview.chromium.org/6329005/diff/15002/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/6329005/diff/15002/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:243: const char
kDisableInteractiveFormValidation[] =
On 2011/01/19 23:34:31, darin wrote:
> nit: please insert in sorted order

Fixed.

http://codereview.chromium.org/6329005/diff/15002/chrome/common/chrome_switch...
File chrome/common/chrome_switches.h (right):

http://codereview.chromium.org/6329005/diff/15002/chrome/common/chrome_switch...
chrome/common/chrome_switches.h:79: extern const char
kDisableInteractiveFormValidation[];
On 2011/01/19 23:34:31, darin wrote:
> nit: please insert in sorted order

Fixed.

I initially named it kDisableFormInteractiveValidation, renamed it to
kDisableInteractiveFormValidation, and forgot to move it.

Expand Messages | Collapse Messages