Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 6328010: Fix Task Manager to correctly display network usage of plug-in processes. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix the way Task Manager accounts for network usage by plug-ins. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager.cc
diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc
index 879ecd5a518d416e028181a59b308dea009ed74f..d407dfb7f0c67b90fcc6e2ec6f29d6397a7de48e 100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -851,10 +851,13 @@ void TaskManagerModel::BytesRead(BytesReadParam param) {
// tab that started a download was closed, or the request may have had
// no originating resource associated with it in the first place.
// We attribute orphaned/unaccounted activity to the Browser process.
- int browser_pid = base::GetCurrentProcId();
- CHECK(param.origin_child_id != browser_pid);
- param.origin_child_id = browser_pid;
- param.render_process_host_child_id = param.routing_id = -1;
+ // TODO(wez): Better results could be achieved by checking with the
+ // ResourceProviders in decreasing order of specialisation, with the
+ // Renderer and Browser resources last, so that fall-back is implicit.
+ CHECK(param.origin_child_id != (-1));
+ param.origin_child_id =
+ param.render_process_host_child_id =
+ param.routing_id = -1;
BytesRead(param);
return;
}

Powered by Google App Engine
This is Rietveld 408576698