cros_mark_as_stable: remove old kernel hack

cros_mark_as_stable: remove old kernel hack

This is no longer needed due to recent cleanup of the ebuild:

http://git.chromium.org/gitweb/?p=chromiumos-overlay.git;a=commit;h=2c58ec2cabfbd2658cc48b2c0cf74e6b5759b483

BUG=11124
TEST=See below.

$ export CROS_WORKON_LOCALNAME="kernel" CROS_WORKON_PROJECT="kernel" eval $(grep -E ^"^CROS_WORKON" kernel-9999.ebuild) && echo $CROS_WORKON_PROJECT $CROS_WORKON_LOCALNAME/$CROS_WORKON_SUBDIR
kernel "../third_party/kernel/files"/

Change-Id: Ib9b0d89b41753b490a9f1e73095ad106beefffa6

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=779babc

[anush, 2011-01-21 18:37:14]

LGTM

On Fri, Jan 21, 2011 at 10:09 AM, <msb@chromium.org> wrote:

> Reviewers: anush,
>
> Description:
> cros_mark_as_stable: remove old kernel hack
>
> This is no longer needed due to recent cleanup of the ebuild:
>
>
>
http://git.chromium.org/gitweb/?p=chromiumos-overlay.git;a=commit;h=2c58ec2ca...
>
> BUG=11124
> TEST=See below.
>
> $ export CROS_WORKON_LOCALNAME="kernel" CROS_WORKON_PROJECT="kernel" eval
> $(grep
> -E ^"^CROS_WORKON" kernel-9999.ebuild) && echo $CROS_WORKON_PROJECT
> $CROS_WORKON_LOCALNAME/$CROS_WORKON_SUBDIR
> kernel "../third_party/kernel/files"/
>
> Change-Id: Ib9b0d89b41753b490a9f1e73095ad106beefffa6
>
> Please review this at http://codereview.chromium.org/6328005/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M cros_mark_as_stable.py
>
>
> Index: cros_mark_as_stable.py
> diff --git a/cros_mark_as_stable.py b/cros_mark_as_stable.py
> index
>
013ccd1ca915fb3f70f00290493d6d24bb73e4c9..8fa635e467ed16f8cca6310e6cbc0387fccc165f
> 100755
> --- a/cros_mark_as_stable.py
> +++ b/cros_mark_as_stable.py
> @@ -361,12 +361,6 @@ class EBuild(object):
>       dir = 'third_party'
>     srcdir = os.path.join(srcroot, dir, subdir)
>
> -    # TODO(anush): This hack is only necessary because the kernel ebuild
> has
> -    # 'if' statements, so we can't grab the CROS_WORKON_LOCALNAME
> properly.
> -    # We should clean up the kernel ebuild and remove this hack.
> -    if not os.path.isdir(srcdir) and subdir == 'kernel/':
> -      srcdir = os.path.join(srcroot, 'third_party/kernel/files')
> -
>     if not os.path.isdir(srcdir):
>       Die('Cannot find commit id for %s' % self.ebuild_path)
>
>
>
>