Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6328002: Update references part 1: subdirectories of chrome/browser/ui/gtk/:... (Closed)

Created:
9 years, 11 months ago by msw
Modified:
9 years, 7 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Update references part 1: subdirectories of chrome/browser/ui/gtk/: (notifications, options, status_icons, tabs, translate) Update all chrome/browser/gtk references & copyright dates of touched files. Re-alphabetize include lists as necessary from this change. Remove the chrome/browser/gtk subdirectories & stubbed headers. BUG=69289 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71668

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -660 lines) Patch
M chrome/browser/chromeos/options/options_window_view.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/gtk/notifications/balloon_view_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/notifications/balloon_view_host_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/advanced_contents_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/advanced_page_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/content_exception_editor.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/content_exceptions_window_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/content_filter_page_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/content_page_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/content_settings_window_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/cookie_filter_page_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/cookies_view.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/fonts_page_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/general_page_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/languages_page_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/managed_prefs_banner_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/options_layout_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/passwords_exceptions_page_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/passwords_exceptions_window_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/passwords_page_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/simple_content_exceptions_window.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/options/url_picker_dialog_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/status_icons/status_icon_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/status_icons/status_tray_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/tabs/dragged_tab_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/tabs/tab_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/tabs/tab_renderer_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/tabs/tab_strip_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/translate/after_translate_infobar_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/translate/before_translate_infobar_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/translate/translate_infobar_base_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/gtk/translate/translate_message_infobar_gtk.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/gtk/bookmark_bar_gtk.cc View 1 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/ui/gtk/bookmark_bar_gtk_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 1 3 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 3 chunks +35 lines, -35 lines 0 comments Download
M chrome/browser/ui/gtk/content_setting_bubble_gtk.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/options/advanced_contents_gtk.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/options/advanced_page_gtk.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/advanced_page_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/content_exception_editor.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/content_exceptions_window_gtk.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/content_exceptions_window_gtk.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/options/content_exceptions_window_gtk_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/options/content_filter_page_gtk.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/options/content_page_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/options/content_page_gtk.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/options/content_settings_window_gtk.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/content_settings_window_gtk.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/options/cookie_filter_page_gtk.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/options/cookies_view.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/cookies_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/cookies_view_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/fonts_languages_window_gtk.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/options/fonts_page_gtk.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/options/general_page_gtk.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/general_page_gtk.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/options/languages_page_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/options/languages_page_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/languages_page_gtk_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/options/managed_prefs_banner_gtk.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/options/options_layout_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/options_window_gtk.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/options/passwords_exceptions_page_gtk.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/options/passwords_exceptions_window_gtk.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/options/passwords_page_gtk.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/options/simple_content_exceptions_window.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/options/simple_content_exceptions_window.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/options/url_picker_dialog_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/options/url_picker_dialog_gtk.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/status_icons/status_icon_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/status_icons/status_tray_gtk.cc View 1 1 chunk +2 lines, -2 lines 1 comment Download
M chrome/browser/ui/gtk/status_icons/status_tray_gtk_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_gtk.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/translate/after_translate_infobar_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/translate/after_translate_infobar_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/translate/before_translate_infobar_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/translate/before_translate_infobar_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/translate/translate_infobar_base_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/translate/translate_infobar_base_gtk.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/translate/translate_message_infobar_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/translate/translate_message_infobar_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/dock_info.cc View 1 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/views/dialog_stubs_gtk.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Please review my second step for issue 69289.
9 years, 11 months ago (2011-01-15 00:35:35 UTC) #1
msw
On 2011/01/15 00:35:35, msw wrote: > Please review my second step for issue 69289. Shoot, ...
9 years, 11 months ago (2011-01-15 00:37:10 UTC) #2
msw
On 2011/01/15 00:37:10, msw wrote: > On 2011/01/15 00:35:35, msw wrote: > > Please review ...
9 years, 11 months ago (2011-01-15 00:56:22 UTC) #3
msw
Please review, thanks. http://codereview.chromium.org/6328002/diff/7004/chrome/browser/ui/gtk/status_icons/status_tray_gtk.cc File chrome/browser/ui/gtk/status_icons/status_tray_gtk.cc (right): http://codereview.chromium.org/6328002/diff/7004/chrome/browser/ui/gtk/status_icons/status_tray_gtk.cc#newcode7 chrome/browser/ui/gtk/status_icons/status_tray_gtk.cc:7: #include "chrome/browser/ui/gtk/status_icons/status_icon_gtk.h" This ordering is okay ...
9 years, 11 months ago (2011-01-15 00:58:47 UTC) #4
Ben Goodger (Google)
9 years, 11 months ago (2011-01-18 16:54:27 UTC) #5 
Looked at a representative subset. LGTM.

Powered by Google App Engine
This is Rietveld 408576698