Issue 6328001: sync: annotate call to join SyncCoreThread to keep ThreadRestrictions happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6328001: sync: annotate call to join SyncCoreThread to keep ThreadRestrictions happy. (Closed)

Created:
9 years, 11 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
willchan no longer on Chromium, Evan Martin, evanm

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

sync: annotate call to join SyncCoreThread to keep ThreadRestrictions happy. Bug 19757 discusses how we block the UI thread on the core thread when shutting down sync. Until that is fixed, we have to fess up to the Thread police. BUG=69570, 19757 TEST=Start syncing in debug build. Stop sync. Don't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71361

Patch Set 1 : allow_io #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	chrome/browser/sync/glue/sync_backend_host.cc	View		2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan thread restriction strikes again!

LGTM

Expand Messages | Collapse Messages