Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 6327018: Add one more Valgrind header (memcheck.h) and update the one we already have.

Created:
9 years, 11 months ago by eugenis
Modified:
9 years, 11 months ago
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, Alexander Potapenko, brettw-cc_chromium.org
Visibility:
Public.

Description

Add one more Valgrind header (memcheck.h) and update the one we already have.

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1266 lines, -120 lines) Patch
M base/third_party/valgrind/README.chromium View 1 1 chunk +6 lines, -7 lines 0 comments Download
A base/third_party/valgrind/memcheck.h View 1 chunk +279 lines, -0 lines 0 comments Download
M base/third_party/valgrind/valgrind.h View 58 chunks +981 lines, -113 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Evgeniy Stepanov
9 years, 11 months ago (2011-01-25 09:54:48 UTC) #1
Alexander Potapenko
http://codereview.chromium.org/6327018/diff/1/base/third_party/valgrind/README.chromium File base/third_party/valgrind/README.chromium (right): http://codereview.chromium.org/6327018/diff/1/base/third_party/valgrind/README.chromium#newcode5 base/third_party/valgrind/README.chromium:5: current process is running under Valgrind, tell Memcheck tool ...
9 years, 11 months ago (2011-01-25 09:57:57 UTC) #2
Evgeniy Stepanov
http://codereview.chromium.org/6327018/diff/1/base/third_party/valgrind/README.chromium File base/third_party/valgrind/README.chromium (right): http://codereview.chromium.org/6327018/diff/1/base/third_party/valgrind/README.chromium#newcode5 base/third_party/valgrind/README.chromium:5: current process is running under Valgrind, tell Memcheck tool ...
9 years, 11 months ago (2011-01-25 10:22:17 UTC) #3
Timur Iskhodzhanov
Am I right that your files are 100%-identical to those in Valgrind SVN? If so ...
9 years, 11 months ago (2011-01-25 15:55:46 UTC) #4
Timur Iskhodzhanov
Also, consider sending a tryjob to linux_valgrind to make sure it compiles fine. On 2011/01/25 ...
9 years, 11 months ago (2011-01-25 15:56:19 UTC) #5
evanm
LGTM
9 years, 11 months ago (2011-01-25 16:57:56 UTC) #6
eugenis
9 years, 11 months ago (2011-01-25 18:14:51 UTC) #7
They are 100% identical. I doubt that I can send a try job, but I'll do
something about it tomorrow.
 On Jan 25, 2011 7:57 PM, <evanm@google.com> wrote:
> LGTM
>
>
> http://codereview.chromium.org/6327018/

Powered by Google App Engine
This is Rietveld 408576698