Issue 6327017: Fix crash when notification disappears under popup menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6327017: Fix crash when notification disappears under popup menu. (Closed)

Created:
9 years, 11 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
John Gregg

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix crash when notification disappears under popup menu. BUG=67101, 51177 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72459

Patch Set 2 : change per review #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -7 lines)			Patch
	M	chrome/browser/ui/cocoa/notifications/balloon_controller.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/notifications/balloon_controller.mm	View	1	2 chunks	+22 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Gregg

lgtm with nit. http://codereview.chromium.org/6327017/diff/1/chrome/browser/ui/cocoa/notifications/balloon_controller.mm File chrome/browser/ui/cocoa/notifications/balloon_controller.mm (right): http://codereview.chromium.org/6327017/diff/1/chrome/browser/ui/cocoa/notifications/balloon_controller.mm#newcode141 chrome/browser/ui/cocoa/notifications/balloon_controller.mm:141: if (delayedClose_) { no { } ...

9 years, 11 months ago (2011-01-25 02:12:42 UTC) #2

thanks, will fix on landing!

Expand Messages | Collapse Messages

Issue 6327017: Fix crash when notification disappears under popup menu. (Closed)

Description

Patch Set 1 #

Patch Set 2 : change per review #

Messages