Issue 6327013: fix cookie info table width for certain locales

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6327013: fix cookie info table width for certain locales (Closed)

Created:
9 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Mike Mammarella

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

fix cookie info table width for certain locales Long cookie contents will now wrap earlier than they need to. CSS really doesn't want to do what we want (wrap the text at the inherited width, or anything except a hardcoded width). So I set the width to be narrower (300 instead of 520) and also set the table's layout to fixed, so that even if 300 is too wide the whole table won't overflow. BUG=69447 TEST=LANGUAGE=fr_FR ./out/Release/chrome Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72026

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/resources/options/cookies_view.css	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mike Mammarella

9 years, 11 months ago (2011-01-20 22:31:30 UTC) #2

On 2011/01/20 22:22:44, Evan Stade wrote:

Aw man, this is totally going to conflict with my changes when I sync. Oh well.
LGTM.

Expand Messages | Collapse Messages