Allow ADM(X) templates to manage both MACHINE and USER policies

Allow ADM(X) templates to manage both MACHINE and USER policies

ADMX policies will have the XML attribute class set to "both", ADM policies will be presented twice, once under CLASS MACHINE, and once under CLASS USER.


BUG=70232
TEST=Add chrome.adm to Group Policy Editor and see if Chrome policies appear both under User Configuration and Machine Configuration, and they can be configured independently. Repeat this with chrome.admx.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72792

[gfeher, 2011-01-20 16:32:35]

Please review.

[Jakob Kummerow, 2011-01-24 16:52:28]

LGTM with two nits and one request for clarification.

http://codereview.chromium.org/6327011/diff/4001/tools/grit/grit/format/polic...
File tools/grit/grit/format/policy_templates/writers/adm_writer.py (right):

http://codereview.chromium.org/6327011/diff/4001/tools/grit/grit/format/polic...
tools/grit/grit/format/policy_templates/writers/adm_writer.py:37: '''Prints a
string with indents and a linebreak to the output.
More accurate would be: "Appends a string with indentation to |self.lines|." or
something like that.
The same goes for the argument comment for "string" below ("The string to append
to self.lines").

http://codereview.chromium.org/6327011/diff/4001/tools/grit/grit/format/polic...
tools/grit/grit/format/policy_templates/writers/adm_writer.py:168: # and footer
of the template will be added in self.EndTemplates().
nit: self.EndTemplate()

http://codereview.chromium.org/6327011/diff/4001/tools/grit/grit/format/polic...
File tools/grit/grit/format/policy_templates/writers/adm_writer_unittest.py
(right):

http://codereview.chromium.org/6327011/diff/4001/tools/grit/grit/format/polic...
tools/grit/grit/format/policy_templates/writers/adm_writer_unittest.py:30:
result.append('CLASS '+clazz)
nit: spaces around '+'

[gfeher, 2011-01-25 10:42:21]

Jakob, I've cleaned up adm_writer.py according to our offline discussion. Please
take another look.

http://codereview.chromium.org/6327011/diff/4001/tools/grit/grit/format/polic...
File tools/grit/grit/format/policy_templates/writers/adm_writer.py (right):

http://codereview.chromium.org/6327011/diff/4001/tools/grit/grit/format/polic...
tools/grit/grit/format/policy_templates/writers/adm_writer.py:168: # and footer
of the template will be added in self.EndTemplates().
On 2011/01/24 16:52:28, jkummerow wrote:
> nit: self.EndTemplate()

Done.

http://codereview.chromium.org/6327011/diff/4001/tools/grit/grit/format/polic...
File tools/grit/grit/format/policy_templates/writers/adm_writer_unittest.py
(right):

http://codereview.chromium.org/6327011/diff/4001/tools/grit/grit/format/polic...
tools/grit/grit/format/policy_templates/writers/adm_writer_unittest.py:30:
result.append('CLASS '+clazz)
On 2011/01/24 16:52:28, jkummerow wrote:
> nit: spaces around '+'

Done.

[gfeher, 2011-01-25 11:29:48]

Did another off-line round.

[Jakob Kummerow, 2011-01-25 11:38:04]

LGTM. Very nice.