Use FilePath::Extension instead of the deprecated file_util::GetFileExtensionFromPath.

chrome/browser/printing/printing_layout_uitest.cc

Index: chrome/browser/printing/printing_layout_uitest.cc
diff --git a/chrome/browser/printing/printing_layout_uitest.cc b/chrome/browser/printing/printing_layout_uitest.cc
index d2cdf9d9900e66c024d01f6e41a41b78866f75a7..9146462b1d73c04467d7b49841e640e350ea6fd3 100644
--- a/chrome/browser/printing/printing_layout_uitest.cc
+++ b/chrome/browser/printing/printing_layout_uitest.cc
@@ -1,8 +1,9 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
+#include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/test/test_file_util.h"
 #include "base/threading/simple_thread.h"
@@ -142,8 +143,8 @@ class PrintingLayoutTest : public PrintingTest<UITest> {
       found_prn = false;
       std::wstring file;
       while (!(file = enumerator.Next().ToWStringHack()).empty()) {
-        std::wstring ext = file_util::GetFileExtensionFromPath(file);
-        if (!_wcsicmp(ext.c_str(), L"emf")) {
+        std::wstring ext = FilePath(file).Extension();
+        if (!_wcsicmp(ext.c_str(), L".emf")) {

[Evan Martin, 2011/01/26 20:10:21]

I suggesting these to use the pattern found in the other file (converting to
UTF8 and dropping the "L"

[tfarina, 2011/01/26 20:21:26]

Done.

Evan, a question:
The description for wcsicmp says:
"compare two wide-character strings, by converting them into lower-case".

Should I bother with this, and convert ext to lower case too (using
base::StringToLowerASCII)?

           EXPECT_FALSE(found_emf) << "Found a leftover .EMF file: \"" <<
               emf_file << "\" and \"" << file << "\" when looking for \"" <<
               verification_name << "\"";
@@ -151,7 +152,7 @@ class PrintingLayoutTest : public PrintingTest<UITest> {
           emf_file = file;
           continue;
         }
-        if (!_wcsicmp(ext.c_str(), L"prn")) {
+        if (!_wcsicmp(ext.c_str(), L".prn")) {
           EXPECT_FALSE(found_prn) << "Found a leftover .PRN file: \"" <<
               prn_file << "\" and \"" << file << "\" when looking for \"" <<
               verification_name << "\"";