Issue 6326011: Revert 72570 - Mac: Enable "Check Spelling While Typing" in Edit menu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6326011: Revert 72570 - Mac: Enable "Check Spelling While Typing" in Edit menu... (Closed)

Created:
9 years, 11 months ago by sail

Modified:
9 years, 7 months ago

Reviewers:
sail

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 72570 - Mac: Enable "Check Spelling While Typing" in Edit menu Currently the "Edit -> Spelling and Grammar -> Check Spelling While Typing" menu item is always disabled. The problem is that the logic to enable / disable this item lives in the render process and not in the UI. This patch implements a generic message that the render process can send to the browser to update the state of view commands. This is used to enable and disable the "Check Spelling While Typing" menu item. BUG=38440 TEST=Clicked in an edit box and verified that the "Check Spelling While Typing" menu item was enabled. Verified that changing the value from the context menu correctly updates the Edit menu as well. TBR=sail@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72571

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -175 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View	4 chunks	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	3 chunks	+0 lines, -40 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	3 chunks	+1 line, -37 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	chrome/common/render_view_commands.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	6 chunks	+12 lines, -47 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages