Issue 6326003: X64 Crnakshaft: Added GeneratePrologue implementation.

Issue 6326003: X64 Crnakshaft: Added GeneratePrologue implementation. (Closed)

Created:
9 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Visibility:
Public.

Description

X64 Crnakshaft: Added GeneratePrologue implementation.

Patch Set 3 : Addressed review comments. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -9 lines)			Patch
M	src/ia32/lithium-codegen-ia32.cc	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/lithium-allocator.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	src/v8globals.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2	1 chunk	+46 lines, -2 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2	2 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/6326003/diff/1/src/x64/lithium-x64.cc File src/x64/lithium-x64.cc (right): http://codereview.chromium.org/6326003/diff/1/src/x64/lithium-x64.cc#newcode318 src/x64/lithium-x64.cc:318: return LStackSlot::Create(index); I would probably make this a ...

9 years, 11 months ago (2011-01-14 12:57:01 UTC) #2

Lasse Reichstein

9 years, 11 months ago (2011-01-14 13:12:30 UTC) #3

http://codereview.chromium.org/6326003/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6326003/diff/1/src/x64/lithium-x64.cc#newcode318
src/x64/lithium-x64.cc:318: return LStackSlot::Create(index);
Made identical to ia32.

http://codereview.chromium.org/6326003/diff/3001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6326003/diff/3001/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:121: #ifdef _MSC_VER
Will do it there as well.

http://codereview.chromium.org/6326003/diff/3001/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:125: for (int offset = slots * kPointerSize - 4 *
KB;
Sadly not, but I'll define a local constant.
It's not something that necessarily makes sense on all platforms.

Expand Messages | Collapse Messages