Issue 6325016: DOMUI: Revert back to v1 sync UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6325016: DOMUI: Revert back to v1 sync UI. (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
csilv, stuartmorgan

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

DOMUI: Revert back to v1 sync UI. Implementing the new Sync Setup flow will require a major refactor that is too large for M10. BUG=61006, 69110 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72343

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -111 lines)			Patch
M	chrome/browser/dom_ui/options/personal_options_handler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/options/personal_options_handler.cc	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.css	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.html	View	1 chunk	+2 lines, -68 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.js	View	4 chunks	+4 lines, -43 lines	0 comments	Download

Total messages: 4 (0 generated)

stuartmorgan

I don't see any new files in the CL; were the files for the dialog ...

9 years, 11 months ago (2011-01-24 16:51:07 UTC) #2

James Hawkins

On 2011/01/24 16:51:07, stuartmorgan wrote: > I don't see any new files in the CL; ...

9 years, 11 months ago (2011-01-24 17:25:53 UTC) #3

stuartmorgan

9 years, 11 months ago (2011-01-24 17:35:34 UTC) #4

LGTM

(I was confused because I was reading 'dialog' to mean one of our overlays.)