Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: webkit/glue/resource_fetcher.h

Issue 6325012: Fix a potential crash by clearing callback_ before running it.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/image_resource_fetcher.cc ('k') | webkit/glue/resource_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/resource_fetcher.h
===================================================================
--- webkit/glue/resource_fetcher.h (revision 71961)
+++ webkit/glue/resource_fetcher.h (working copy)
@@ -75,9 +75,6 @@
// URL we're fetching
GURL url_;
- // Callback when we're done
- scoped_ptr<Callback> callback_;
-
// A copy of the original resource response
WebKit::WebURLResponse response_;
@@ -88,6 +85,12 @@
// Start the actual download.
void Start(WebKit::WebFrame* frame);
+ void RunCallback(const WebKit::WebURLResponse& response,
+ const std::string& data);
+
+ // Callback when we're done
+ scoped_ptr<Callback> callback_;
+
// Buffer to hold the content from the server.
std::string data_;
« no previous file with comments | « webkit/glue/image_resource_fetcher.cc ('k') | webkit/glue/resource_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698