Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 6325005: Relanding r71472....

Created:
9 years, 11 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Relanding r71472. Use GL rather than EGL by default on linux. Debug Chromium builds display an error if they don't find EGL, even if GLX is available. This prompts people to install the EGL packages, even though that probably isn't their issue. Also, it looks like EGL, even if available, has some issues. If GLX isn't available, it still falls back to EGL. --use-gl=desktop should not be required to force use of GLX on boxes that also have EGL installed. Changed LOG(ERROR) to VLOG(1) if a shared library fails to load since this is not necessarily an error. Report an error only if no GL implementation can be initialized. Log which GL implementation was selected. TEST=launch chrome with various combinations of --use-gl switch and check the log output is correct. BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -29 lines) Patch
M app/gfx/gl/gl_context_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/gfx/gl/gl_implementation.h View 1 chunk +3 lines, -0 lines 0 comments Download
M app/gfx/gl/gl_implementation.cc View 3 chunks +34 lines, -19 lines 0 comments Download
M app/gfx/gl/gl_implementation_linux.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M app/gfx/gl/gl_implementation_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/gfx/gl/gl_implementation_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698