Tweak the auto-open algorithm to permit JNLP to auto-open iff the user has...

Tweak the auto-open algorithm to permit JNLP to auto-open iff the user has
set auto-open on JNLP, and the JNLP file arrives courtesy of a user click.

BUG=10877
TEST=http://phet.colorado.edu/simulations/sims.php?sim=John_Travoltage


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73080

[Randy Smith (Not in Mondays), 2011-01-28 23:44:46]

On 2011/01/28 23:19:49, Chris Evans wrote:

Chris: You didn't specify a reviewer, but LGTM.  I've added Peter as well,
though, since I think he's familiar with this code in a different way than I. 
And if you want someone else as a reviewer, you should also add them :-}.

[Peter Kasting, 2011-01-28 23:51:25]

LGTM

http://codereview.chromium.org/6324020/diff/1/chrome/browser/download/downloa...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/6324020/diff/1/chrome/browser/download/downloa...
chrome/browser/download/download_util.cc:770: if (auto_open &&
info->has_user_gesture) {
Two nits:

* Can condense this whole block to "return !auto_open ||
!info->has_user_gesture"

* Never "else" after "return" (please fix remainder of function while here).

http://codereview.chromium.org/6324020/diff/1/chrome/browser/download/downloa...
File chrome/browser/download/download_util.h (right):

http://codereview.chromium.org/6324020/diff/1/chrome/browser/download/downloa...
chrome/browser/download/download_util.h:210: // Whether a given download should
be considered potentially dangerous.
Two nits:

* It'd be nice to expand the comment here, e.g.:

// Returns true if this download should show the "dangerous file" warning.  This
may vary depending on whether the user explicitly initiated the download and
whether the user has marked this filetype as "auto open" (both of which reduce
the likelihood that we'll show a warning).

* Please fix "DownloadCreateInfo *info" while here.

[Chris Evans, 2011-01-29 03:12:01]

On 2011/01/28 23:51:25, Peter Kasting wrote:
> LGTM
> 
>
http://codereview.chromium.org/6324020/diff/1/chrome/browser/download/downloa...
> File chrome/browser/download/download_util.cc (right):
> 
>
http://codereview.chromium.org/6324020/diff/1/chrome/browser/download/downloa...
> chrome/browser/download/download_util.cc:770: if (auto_open &&
> info->has_user_gesture) {
> Two nits:
> 
> * Can condense this whole block to "return !auto_open ||
> !info->has_user_gesture"

Done (used !(a&&b) construct)

> 
> * Never "else" after "return" (please fix remainder of function while here).

Done

> 
>
http://codereview.chromium.org/6324020/diff/1/chrome/browser/download/downloa...
> File chrome/browser/download/download_util.h (right):
> 
>
http://codereview.chromium.org/6324020/diff/1/chrome/browser/download/downloa...
> chrome/browser/download/download_util.h:210: // Whether a given download
should
> be considered potentially dangerous.
> Two nits:
> 
> * It'd be nice to expand the comment here, e.g.:
> 
> // Returns true if this download should show the "dangerous file" warning. 
This
> may vary depending on whether the user explicitly initiated the download and
> whether the user has marked this filetype as "auto open" (both of which reduce
> the likelihood that we'll show a warning).

Agree, done.

> 
> * Please fix "DownloadCreateInfo *info" while here.

Done.