Issue 6324013: ARM: Add subtract to the type recording binary operation stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6324013: ARM: Add subtract to the type recording binary operation stub. (Closed)

Created:
9 years, 11 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Alexandre, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Add subtract to the type recording binary operation stub. Committed: http://code.google.com/p/v8/source/detail?r=6476

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -17 lines)			Patch
M	src/arm/code-stubs-arm.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	10 chunks	+52 lines, -16 lines	2 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexandre

http://codereview.chromium.org/6324013/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6324013/diff/1/src/arm/code-stubs-arm.cc#newcode2452 src/arm/code-stubs-arm.cc:2452: __ sub(right, left, Operand(right)); // Revert optimistic subtract. Shouldn't ...

9 years, 11 months ago (2011-01-25 16:51:15 UTC) #3

Alexandre

9 years, 11 months ago (2011-01-25 16:54:44 UTC) #4

http://codereview.chromium.org/6324013/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6324013/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2452: __ sub(right, left, Operand(right));  // Revert
optimistic subtract.
Sorry I messed up with these right and left.
On 2011/01/25 16:51:15, Alexandre wrote:
> Shouldn't it be an add(right, right, Operand(left)); ?

Expand Messages | Collapse Messages