Issue 6324011: Implement x64 lithium instructions DoGlobalObject and DoSub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6324011: Implement x64 lithium instructions DoGlobalObject and DoSub (Closed)

Created:
9 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Implement x64 lithium instructions DoGlobalObject and DoSub Committed: http://code.google.com/p/v8/source/detail?r=6456

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -6 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View		2 chunks	+18 lines, -2 lines	1 comment	Download
	M	src/x64/lithium-x64.cc	View		2 chunks	+18 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

9 years, 11 months ago (2011-01-25 11:12:20 UTC) #2

LGTM with comments addressed.

http://codereview.chromium.org/6324011/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6324011/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:1595: Register result =
ToRegister(instr->result());
GlobalObjectOperand()

http://codereview.chromium.org/6324011/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6324011/diff/1/src/x64/lithium-x64.cc#newcode1189
src/x64/lithium-x64.cc:1189: LInstruction* result = DefineSameAsFirst(sub);
Subtraction is not commutative.  I don't think you can scramble the operands, to
put the least constant on the left.

Expand Messages | Collapse Messages