Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: chrome/browser/media_uitest.cc

Issue 6324010: Un-mark UILayoutTests as flaky (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "app/gfx/gl/gl_implementation.h" 5 #include "app/gfx/gl/gl_implementation.h"
6 #include "base/basictypes.h" 6 #include "base/basictypes.h"
7 #include "base/file_path.h" 7 #include "base/file_path.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "base/test/test_timeouts.h" 9 #include "base/test/test_timeouts.h"
10 #include "base/threading/platform_thread.h" 10 #include "base/threading/platform_thread.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 59
60 void PlayAudio(const char* url) { 60 void PlayAudio(const char* url) {
61 PlayMedia("audio", url); 61 PlayMedia("audio", url);
62 } 62 }
63 63
64 void PlayVideo(const char* url) { 64 void PlayVideo(const char* url) {
65 PlayMedia("video", url); 65 PlayMedia("video", url);
66 } 66 }
67 }; 67 };
68 68
69 #if defined(OS_LINUX) || defined(OS_WIN)
70 // Test appears to be fine on linux, but let's first change to flaky and
71 // see how that goes.
72 // http://crbug.com/56364
73 #define MediaUILayoutTest FLAKY_MediaUILayoutTest
74 #endif
75
76 TEST_F(MediaTest, VideoBearTheora) { 69 TEST_F(MediaTest, VideoBearTheora) {
77 PlayVideo("bear.ogv"); 70 PlayVideo("bear.ogv");
78 } 71 }
79 72
80 TEST_F(MediaTest, VideoBearSilentTheora) { 73 TEST_F(MediaTest, VideoBearSilentTheora) {
81 PlayVideo("bear_silent.ogv"); 74 PlayVideo("bear_silent.ogv");
82 } 75 }
83 76
84 TEST_F(MediaTest, VideoBearWebm) { 77 TEST_F(MediaTest, VideoBearWebm) {
85 PlayVideo("bear.webm"); 78 PlayVideo("bear.webm");
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 InitializeForLayoutTest(test_dir, media_test_dir, kNoHttpPort); 119 InitializeForLayoutTest(test_dir, media_test_dir, kNoHttpPort);
127 120
128 // Copy resources first. 121 // Copy resources first.
129 for (size_t i = 0; i < arraysize(kResources); ++i) 122 for (size_t i = 0; i < arraysize(kResources); ++i)
130 AddResourceForLayoutTest( 123 AddResourceForLayoutTest(
131 test_dir, media_test_dir.AppendASCII(kResources[i])); 124 test_dir, media_test_dir.AppendASCII(kResources[i]));
132 125
133 for (size_t i = 0; i < arraysize(kMediaTests); ++i) 126 for (size_t i = 0; i < arraysize(kMediaTests); ++i)
134 RunLayoutTest(kMediaTests[i], kNoHttpPort); 127 RunLayoutTest(kMediaTests[i], kNoHttpPort);
135 } 128 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698